Skip to content

Adapt to Swiftmailer 5 and Swiftmailer 6 version of class Swift_ConfigurableSpool#279

Open
thirsch wants to merge 1 commit into
FriendsOfSymfony1:masterfrom
vemaeg:feature/swiftmailer-6-compat
Open

Adapt to Swiftmailer 5 and Swiftmailer 6 version of class Swift_ConfigurableSpool#279
thirsch wants to merge 1 commit into
FriendsOfSymfony1:masterfrom
vemaeg:feature/swiftmailer-6-compat

Conversation

@thirsch
Copy link
Copy Markdown
Collaborator

@thirsch thirsch commented Feb 7, 2023

@thePanz as promised, here is a possible solution of the swiftmailer issue. What do you think?

Btw. as the swiftmailer package is discontinued but needs a small adjustment for php 8.2: Should we clone the official repo in fos1 as well or try to adapt to symfony/mailer?

@connorhu
Copy link
Copy Markdown
Collaborator

connorhu commented Feb 9, 2023 •
edited
Loading

+1 for symfony/mailer wrapper as a mailer plugin.

@thePanz
Copy link
Copy Markdown
Member

thePanz commented Feb 10, 2023

For reference: #240 (comment)

thePanz
thePanz requested changes Feb 10, 2023
View reviewed changes
Comment thread lib/plugins/sfDoctrinePlugin/lib/mailer/Swift_DoctrineSpool.class.php Outdated
@thirsch thirsch force-pushed the feature/swiftmailer-6-compat branch from 2e2bd83 to d6fc1b0 Compare February 11, 2023 08:52
@thirsch
Copy link
Copy Markdown
Collaborator Author

thirsch commented Feb 11, 2023

Do you have any experience, how to use the spool? I've thought about creating a test for it. While browsing the test sources, I've come across https://github.com/FriendsOfSymfony1/symfony1/blob/master/test/unit/mailer/fixtures/TestSpool.class.php which is referencing Swift_Mime_Message as well.

@connorhu
Copy link
Copy Markdown
Collaborator

connorhu commented Feb 13, 2023 •
edited
Loading

I am currently using Swfitmailer with spool under Symfony5. I can figure out how to set it up here.

@thePanz
Copy link
Copy Markdown
Member

thePanz commented Feb 13, 2023

we might need to run the tests on the CI with --prefer-lowest to test both versions of the SwiftMailer, wdyt?

@connorhu
Copy link
Copy Markdown
Collaborator

connorhu commented Feb 15, 2023

@thirsch File(system) spool example configuration:

factories.yml

  mailer:
    param:
      delivery_strategy: spool
      spool_class: Swift_FileSpool
      spool_arguments:
        - "spoolpath"

image

@connorhu
Copy link
Copy Markdown
Collaborator

connorhu commented Feb 15, 2023

Btw I found this about spools:
https://symfony.com/legacy/doc/more-with-symfony/1_4/en/04-Emails#chapter_04_sub_the_spool_strategy

@alquerci alquerci mentioned this pull request Jan 1, 2024
Open
@thirsch thirsch mentioned this pull request Mar 24, 2024
Open
thePanz
thePanz requested changes Mar 4, 2025
View reviewed changes
Comment thread lib/plugins/sfDoctrinePlugin/lib/mailer/Swift_DoctrineSpool.class.php
* Stores a message in the queue.
*
* @param Swift_Mime_Message $message The message to store
* @param $message The message to store
Copy link
Copy Markdown
Member

@thePanz thePanz Mar 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* @param $message The message to store
* @param object $message The message to store

wdyt @thirsch ?

@thePanz
Copy link
Copy Markdown
Member

thePanz commented Mar 4, 2025

Btw I found this about spools: https://symfony.com/legacy/doc/more-with-symfony/1_4/en/04-Emails#chapter_04_sub_the_spool_strategy

Does it mean that the Swift_FileSpool should be adapted too?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thePanz thePanz thePanz requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@thirsch @connorhu @thePanz